[BEAM-13203] Potential data loss when using SnsIO.writeAsync

• Type: Bug
• Status: Resolved
• Priority: P1
• Resolution: Won't Fix
• Fix Version/s: 2.37.0
• Component/s: io-java-aws
• Assignee: Moritz Mack
• Reporter: Moritz Mack
• Created: 08/Nov/21 18:44
• Updated: 04/Feb/22 15:14
• Resolved: 04/Feb/22 15:14

Description

This needs to be investigated, reading the code suggests we might be losing data under certain conditions e.g. when terminating the pipeline. The async processing model here is far too simplistic.

The bundle won't ever know about pending writes and won't block to wait for any such operation. The same way exceptions are thrown into nowhere. Test cases don't capture this as they operate on completed futures only (so exceptions in the callbacks get thrown on the thread of processElement).

client.publish(publishRequest).whenComplete((response, ex) -> {
  if (ex == null) {
    SnsResponse<T> snsResponse = SnsResponse.of(context.element(), response);
    context.output(snsResponse);
  } else {
    LOG.error("Error while publishing request to SNS", ex);
    throw new SnsWriteException("Error while publishing request to SNS", ex);
  }
}); 

Also, this entirely removes backpressure from a stream. When used with a much faster source we will continue to accumulate more and more memory as the number of concurrent pending async operations is not limited.

Spotify's scio contains a JavaAsyncDoFn that illustrates how it can be done.

Issue Links

• relates to: BEAM-8542 Add async write to AWS SNS IO & remove retry logic
• relates to: BEAM-13824 Migrate SnsIO.write to async implementation
• links to: GitHub Pull Request #16711