Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-12768

test_df_agg_method_invalid_kwarg_raises test too strict on error/string matching

Details

    • Bug
    • Status: Resolved
    • P0
    • Resolution: Fixed
    • 2.33.0
    • 2.33.0
    • sdk-py-core, test-failures
    • None

    Description

      It looks like possibly the restricted pandas version to 1.3.0 made the type error message contents change slightly. Looks like we should relax https://github.com/apache/beam/blame/faac725e98f8422b172a77e8c898af03c15b74c6/sdks/python/apache_beam/dataframe/frames_test.py#L98 to possibly be a substring test

      Example failure:
      https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/4563/testReport/junit/apache_beam.dataframe.frames_test/AggregationTest/test_df_agg_method_invalid_kwarg_raises/

      AssertionError: Expected TypeError("mean() got an unexpected keyword argument 'bool_only'") to be raised, but got TypeError("DataFrame constructor called with incompatible data and dtype: mean() got an unexpected keyword argument 'bool_only'")
      

      Attachments

        Issue Links

          Activity

            People

              lcwik Luke Cwik
              lcwik Luke Cwik
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 2h
                  2h