Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-12253

Read.UnboundedSourceAsSDFRestrictionTracker doesn't use cache for readers in getProgress

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.31.0
    • Component/s: sdk-java-core
    • Labels:
      None

      Description

      https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java#L963

      In getProgress, if currentReader == null a new reader is constructed from the restriction checkpoint. I think that we should consult the reader cache as creating readers is sometimes expensive.

      I observed in Nexmark pipelines that readers were being created at this location.

        Attachments

          Activity

            People

            • Assignee:
              scwhittle Sam Whittle
              Reporter:
              scwhittle Sam Whittle

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h
                2h

                  Issue deployment