[BEAM-12253] Read.UnboundedSourceAsSDFRestrictionTracker doesn't use cache for readers in getProgress

• Type: Bug
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.31.0
• Component/s: sdk-java-core
• Assignee: Sam Whittle
• Reporter: Sam Whittle
• Created: 29/Apr/21 11:33
• Updated: 04/May/21 06:58
• Resolved: 04/May/21 06:58

Description

https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java#L963

In getProgress, if currentReader == null a new reader is constructed from the restriction checkpoint. I think that we should consult the reader cache as creating readers is sometimes expensive.

I observed in Nexmark pipelines that readers were being created at this location.

Issue Links

• links to: GitHub Pull Request #14704