[BEAM-12247] Reduce memory allocations in InMemoryTimerInternals

• Type: Task
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Fix Version/s: 2.30.0
• Component/s: sdk-java-core
• Assignee: Daniel Kulp
• Reporter: Daniel Kulp
• Created: 28/Apr/21 18:16
• Updated: 29/Apr/21 06:15
• Resolved: 29/Apr/21 06:15

Description

Doing some profiling, there are a lot of unnecessary allocations occurring in InmemoryTimerInternals:

1) Every WindowTracing.trace call calls getClass().getSimpleName() which searches the class name for a "." and then creates a substring which is then discarded if tracing is not on. This can be cached easily.

2) In setTimer, the column key (timerData.getTimerId() + '+' + timerData.getTimerFamilyId()) is computed twice each time which involves string builders, appends, etc...