[BEAM-10832] ClickhouseIO's getTableSchema method is called before Pipeline Starts

• Type: Improvement
• Status: Resolved
• Priority: P2
• Resolution: Fixed
• Affects Version/s: 2.23.0
• Fix Version/s: 2.26.0
• Component/s: io-java-clickhouse
• Assignee: Vasu Gupta
• Reporter: Vasu Gupta
• Created: 28/Aug/20 16:20
• Updated: 15/Jan/22 01:06
• Resolved: 15/Jan/22 01:06

Description

A method in ClickhouseIO called getTableSchema() is being used in WriteFn's expand method which is called even before the Pipeline is started. The main issue is that getTableSchema() makes a connection with Clickhouse and if at the time of just pipeline launch, if i can't connect to a clickhouse-server, the pipeline won't even start. Let's suppose there is a clickhouse server deployed on a production server, now if i want to launch a DataFlow pipeline from my local then i shouldn't be requiring a working connection to clickhouse-server from my local environment (but i should be able to connect to clickhouse-server from dataflow).

 

What i suggest:

getTableSchema() should be a singleton method and must be called in setup() method (instead of PTransform's expand method) of DoFn since setup method is called after the pipeline is started (In my case "at DataFlow" not local)

 

I would be more than happy to work on this improvement in Apache Beam (Java).

 

 

Issue Links

• links to: GitHub Pull Request #12919