Uploaded image for project: 'Beam'
  1. Beam
  2. BEAM-10611

Use ZetaSQL Value.createDatetimeValue(LocalDateTime) function to avoid extra conversions

Details

    • Improvement
    • Status: Resolved
    • P3
    • Resolution: Fixed
    • None
    • 2.24.0
    • dsl-sql-zetasql
    • None

    Description

      GoogleSQL (internal) has a Value.createDatetimeValue() method that takes a Java LocalDateTime, but it has not been open-sourced to ZetaSQL. We should open source this function and then Beam should use it to replace the current DATETIME type translation implementation. It will avoid unnecessary conversions and make the code simpler.

      Attachments

        Issue Links

          Activity

            People

              robinyqiu Robin Qiu
              robinyqiu Robin Qiu
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m