Details

    • Sub-task
    • Status: Open
    • P3
    • Resolution: Unresolved
    • None
    • None
    • io-java-gcp, sdk-java-core

    Description

      One known issue is "*" is not allowed in Windows OS.
      For example, Paths.get("tempDir/*") might throw when code runs in Windows OS.
      http://stackoverflow.com/questions/27522581/asterisks-in-java-path

      This affecting IOChannelFactory.resolve(), toPath(), and match().

      For match(), since it only requires support globs in the final component of a path. (local) FileIOChannelFactory could do things similar as GcsIOChannelFactory:
      First, list all files under the directory path (this won't contain glob, such as *).
      Then, check each returned files whether it matches glob.
      In this way, glob stays within Apache Beam's code.

      From match()'s javadoc:
      """
      Glob handling is dependent on the implementation. Implementations should

      • all support globs in the final component of a path (eg /foo/bar/*.txt),
      • however they are not required to support globs in the directory paths.
        """

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              peihe0@gmail.com Pei He
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: