[BCEL-78] NullPointerException in InstructionHandle

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1
• Fix Version/s: 5.2
• Component/s: Main
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=38834
• External issue ID: 38834
• Assignee: Apache Commons Developers
• Reporter: bergrei
• Created: 02/Mar/06 19:13
• Updated: 24/Apr/14 12:12
• Resolved: 02/Mar/06 16:50

Description

please add missing checks for null references in InstructionHandle.java to
avoid null pointer exceptions:

A) in line 161

  /**
   * Denote this handle isn't referenced anymore by t.
   */
  public void removeTargeter(InstructionTargeter t) {
==ADD==>    if (targeters != null)
      targeters.remove(t);
  }

B) in line 238

  /** @return all attributes associated with this handle
   */
  public Collection getAttributes() {
==ADD==>    if(attributes == null)
==ADD==>      attributes = new HashMap(3);
    return attributes.values();
  }