[BCEL-63] JavaClass.dump(OutputStream/DataOutputStream) shouldnt call close

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1
• Fix Version/s: 5.2
• Component/s: Main
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=34318
• External issue ID: 34318
• Assignee: Apache Commons Developers
• Reporter: sam
• Created: 06/Apr/05 03:15
• Updated: 24/Apr/14 12:43
• Resolved: 07/Apr/05 21:01

Description

I think it would be more helpful if JavaClass.dump(*OutputStream)
didnt call close as the caller may not be finished with the stream.

Only for JavaClass.dump(File) does BCEL "own" the OutputStream.

It also looks like the caller should provide an extra finally

{... os.close() }

as JavaClass.dump may not close the stream in the event of an error.

For a concrete example: When writing a JAR using JarOutputStream
the stream shouldnt be closed till multiple classes have been written.
So the real stream has to be wrapped with a Filter/Proxy that ignores close.

This problem also appears for ClassParser.

Many thanks for your excellent code.