[BCEL-370] CONSTANT_Dynamic is not handled in LDC

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.7.0
• Fix Version/s: 6.8.1
• External issue URL: https://github.com/spotbugs/spotbugs/issues/2503

Language

Java

• Assignee: Unassigned
• Reporter: Judit Knoll
• Created: 10/Oct/23 08:27
• Updated: 09/Jan/24 07:57
• Resolved: 06/Jan/24 20:42

Description

The org.apache.bcel.generic.LDC class does not support Const.CONSTANT_Dynamic (Condy, Dynamic class-file constant) in the following methods:

• public Type getType(final ConstantPoolGen cpg);
• public Object getValue(final ConstantPoolGen cpg);

JaCoCo >= 0.8.4 (see jacoco/pull/845) creates class files which have Constant_Dynamic. When visiting the instructions of a method and calling either of the mentioned method of LDC, an IllegalArgumentException occurs: "Unknown or invalid constant type at 32".

This error causes a problem, when someone tries to analyze a class file containing condy with spotbugs, which uses BCEL. The error was originally found in spotbugs (see spotbugs/issues/2503 and spotbugs/pull/2512).

Attached a class built by Java 17 and JaCoCo 0.8.9., the source of this file is spotbugs/issues/2503/comment.
The issue can be reproduced by calling the org.apache.bcel.generic.TypeTestCase.testLDC(String className) method with the attached class file as a parameter.

Issue Links

• links to: GitHub Pull Request #254