[BCEL-37] OutOfRange exception in Pass2Verifier.validJavaIdentifier

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1
• Fix Version/s: 5.2
• Component/s: Main
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=26087
• External issue ID: 26087
• Assignee: Apache Commons Developers
• Reporter: Francis ANDRE
• Created: 13/Jan/04 11:25
• Updated: 24/Apr/14 12:36
• Resolved: 16/Nov/04 19:05

Description

Hi

Pass2Verifier.validJavaIdentifier must check the length of the parameter "name" otherwise an OutOfRange exception occurs when name.length() == 0. Here is the patch.

Index: Pass2Verifier.java
===================================================================
RCS 
file: /cvsroot/bcel/JustIce/de/fub/bytecode/verifier/statics/Pass2Verifier.java,
v
retrieving revision 1.69
diff -u -r1.69 Pass2Verifier.java
--- Pass2Verifier.java	12 Sep 2001 12:56:15 -0000	1.69
+++ Pass2Verifier.java	13 Jan 2004 11:12:40 -0000
@@ -1222,6 +1222,7 @@
 	 * represents a valid Java identifier (so-called simple name).
 	 */
 	private static boolean validJavaIdentifier(String name){
+		if  (name.length() == 0) return false;
 		// vmspec2 2.7, vmspec2 2.2
 		if (!Character.isJavaIdentifierStart(name.charAt(0))) return false;

Regards

FA