[BCEL-313] ClassFormatException: Invalid signature: Ljava/lang/String)V in Verifier Pass 3A

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.2
• Fix Version/s: 6.8.0
• Component/s: Verifier
• Assignee: Unassigned
• Reporter: Rohan Padhye
• Created: 23/Aug/18 02:57
• Updated: 17/Jun/23 18:16
• Resolved: 17/Jun/23 18:16

Description

 

Verifier pass 3A throws an unchecked ClassFormatException when presented with malformed input instead of returning a VERIFIER_REJECTED.

Steps to reproduce:

 

Save the attached file as "Hello.class" and run:

java -cp <classpath> org.apache.bcel.verifier.Verifier Hello

 

The file Hello.class was generated automatically by the fuzzer JQF (https://github.com/rohanpadhye/jqf).

Expected output:

VERIFIED_REJECTED

Observed output:

JustIce by Enver Haase, (C) 2001-2002.

<http://bcel.sourceforge.net>

<http://commons.apache.org/bcel>

Now verifying: Hello

 

Pass 1:

VERIFIED_OK

Passed verification.

 

Pass 2:

VERIFIED_OK

Passed verification.

 

Pass 3a, method number 0 ['public void <init>()']:

VERIFIED_OK

Passed verification.

 

Pass 3b, method number 0 ['public void <init>()']:

VERIFIED_OK

Passed verification.

 

Exception in thread "main" org.apache.bcel.classfile.ClassFormatException: Invalid signature: Ljava/lang/String)V

at org.apache.bcel.classfile.Utility.signatureToString(Utility.java:850)

at org.apache.bcel.generic.Type.getType(Type.java:217)

at org.apache.bcel.generic.Type.getArgumentTypes(Type.java:256)

at org.apache.bcel.generic.InvokeInstruction.getArgumentTypes(InvokeInstruction.java:134)

at org.apache.bcel.verifier.statics.Pass3aVerifier$InstOperandConstraintVisitor.visitInvokeInstruction(Pass3aVerifier.java:721)

at org.apache.bcel.generic.INVOKEVIRTUAL.accept(INVOKEVIRTUAL.java:88)

at org.apache.bcel.generic.InstructionHandle.accept(InstructionHandle.java:302)

at org.apache.bcel.verifier.statics.Pass3aVerifier.pass3StaticInstructionOperandsChecks(Pass3aVerifier.java:443)

at org.apache.bcel.verifier.statics.Pass3aVerifier.do_verify(Pass3aVerifier.java:208)

at org.apache.bcel.verifier.PassVerifier.verify(PassVerifier.java:71)

at org.apache.bcel.verifier.Verifier.doPass3a(Verifier.java:89)

at org.apache.bcel.verifier.Verifier.main(Verifier.java:216)