[BCEL-112] ARRAYLENGTH incorrectly not StackConsumer

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.8.1
• Fix Version/s: 6.0
• Component/s: Main
• Labels: PatchAvailable
• External issue URL: https://issues.apache.org/bugzilla/show_bug.cgi?id=43391
• External issue ID: 43391
• Assignee: Apache Commons Developers
• Reporter: Zappacky
• Created: 13/Sep/07 16:03
• Updated: 07/Dec/23 21:04
• Resolved: 02/Feb/08 13:10

Description

According to the JVM Instruction Set, ARRAYLENGTH pops a value from the stack
and pushes a value to the stack. In BCEL, it only implements StackProducer, so
it creates an incorrectly high stack height. The Constants class already has the
correct value for it, but since the instruction does not implement StackConsumer
it is never used. The easiest solution is to change
src\java\src\java\org\apache\bcel\generic\ARRAYLENGTH.java to implement
StackConsumer. This will fix the bug.

I didn't attach a patch for this because the change is so tiny.