[BATIK-896] Stream incorrectly closed in Services - triggers NPE and swallows original Exception

• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Affects Version/s: 1.8
• Component/s: Utilities
• Environment: Operating System: All; Platform: PC
• Assignee: Batik Developer's Mailing list
• Reporter: Fabrizio Giudici
• Created: 18/Mar/09 00:51
• Updated: 18/Mar/09 19:52
• Resolved: 18/Mar/09 19:52

Description

Hello.

The class org.apache.batik.util.Services incorrectly closes a stream, causing in some cases a NPE that swallows the original exception. This has personally caused quite a mess for finding an error in a custom application that triggered this.

The culprit is this code:

if ( br == null ){
try

{ br.close(); }

catch ( IOException ignored ){}
br = null;
}

Where clearly the test should be if (br != null). Attaching the svn diff of the patch:

Index: Service.java
===================================================================
— Service.java (revision 755499)
+++ Service.java (working copy)
@@ -146,7 +146,7 @@
} catch ( IOException ignored ){}
r = null;
}

• if ( br == null ){
  + if ( br != null ){
  try { br.close(); }

  catch ( IOException ignored ){}