[BAHIR-152] License header not enforced for Java sources

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Not Applicable
• Fix Version/s: Spark-2.2.1, Spark-2.3.0
• Component/s: Build, Spark SQL Data Sources, Spark Streaming Connectors, Spark Structured Streaming Connectors
• Assignee: Christian Kadner
• Reporter: Christian Kadner
• Created: 10/Dec/17 01:36
• Updated: 11/Dec/17 05:10
• Resolved: 10/Dec/17 16:14

Description

In any Java source file add this line on top of the license header:

/*
 * Copyright (c) 2017 ACME. All rights reserved.
 * <p>

then run mvn clean verify and see the build succeed.

Neither of the following maven goals complains either:

• mvn apache-rat:check
• mvn checkstyle:check

Adding a similar copyright statement to any of the Scala sources will fail the HeaderMatchesChecker rule in our scalastyle checks.

I am not sure why the RAT checks allow this to pass, but I will add a similar Header verification to our checkstyle configuration.

Issue Links

• links to: GitHub Pull Request #58