[AXISCPP-922] Resource leak in AttachmentHelper::extract_Attachment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6 Final
• Fix Version/s: current (nightly)
• Component/s: Server - Deserialization
• Environment: All platforms, this issue was found in nightly drop 24-Jan-2006 21:23
• Assignee: Unassigned
• Reporter: Emanuel Norrbin
• Created: 26/Jan/06 10:35
• Updated: 27/Jan/07 06:51
• Resolved: 27/Jan/07 06:51

Description

File: server\apache2\AttachmentHelper.cpp
Method: void AttachmentHelper::extract_Attachment(char *pBuffer)
Line: 88 - 89

This is a very easy bug to spot and fix:

xsd_base64Binary* base64_attachment = new xsd_base64Binary();
base64_attachment = AxisUtils::decodeFromBase64Binary(attach);

In Java this code would be fine but in C++ is is a resource leak,
the first new is not needed since decodeFromBase64Binary will allocate the xsd__base64Binary.
I suggest replacing the two lines with this one:

xsd__base64Binary* base64_attachment = AxisUtils::decodeFromBase64Binary(attach);

/Emanuel