[AXISCPP-870] IChannel operator >>() should not have const parameter.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5 Final
• Fix Version/s: 1.6 Alpha
• Component/s: Transport (axis3)
• Assignee: Nadir K. Amra
• Reporter: Duane Murphy
• Created: 11/Nov/05 04:03
• Updated: 06/Jun/06 03:15
• Resolved: 14/Feb/06 00:53

Description

The function signature

virtual const IChannel& operator >> (const char * msg)=0;

from IChannel.h should not have the parameter be const. The correct signature should be:

virtual const IChannel& operator >> (char * msg)=0;

Input streaming operators are non-const. The value of msg will be overwritten by the operator by definition. This function is implemented by casting away const.

Note: this functions signature is also used in the axis2 IChannel interface.

Note: that this function is inherently dangerous as it assumes that msg points to at least BUF_SIZE storage. Using a std::string or std::vector<char> would be a better choice.