[AXISCPP-721] Axis###Exception::getMessage() returns a static variable

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: current (nightly)
• Component/s: Server - Engine
• Assignee: Marcus Dushshantha Chandradasa
• Reporter: Henrik Nordberg
• Created: 01/Jul/05 02:26
• Updated: 06/Jul/05 14:25
• Resolved: 05/Jul/05 20:06

Description

Axis exceptions' method getMessage() returns a static variable. Here is an example of the code for AxisSoapException:

const string AxisSoapException::getMessage (const exception* objException)
{
static string objExDetail = objException->what();

return objExDetail;
}

What is the purpose of making objExDetail static? Doing so means that it is initialized the first time this method is called (once per instance of the class), and after that the same value will be returned no matter what objException is. Here is a version without static:

string AxisSoapException::getMessage (const exception& objException) const {
return objException.what();
}

I also made the method const since we will not modify members. Also why use a pointer when we don't have to?
I also think that since this code is common between Axis exceptions, it should be move to a common base class.