Uploaded image for project: 'Axis-C++'
  1. Axis-C++
  2. AXISCPP-407

Call->getFaultDetail() API should be removed or implemented

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5 Final
    • Basic Architecture
    • None

    Description

      The public API Call->getFaultDetail(char** ppcDetail) sets the value of the private class member variable m_pcFaultDetail in the SoapDeSerializer class into ppcDetail. This member variable is only initialized in the SoapDeSerializer->getFault() method which is never called, and even if it was it sets it to a hard coded string.

      What is the purpose of the getFaultDetail API. Has it been superceded by the ISoapFault interface? If so should the API be removed or implemented to use the ISoapFault interface?

      I feel that the API should be removed as obviously nothing uses it.

      Attachments

        Activity

          Yes I too think that this is not any more needed.

          What we really do is to map the Fault details to an exception. So those who want fault details should deal with the exception.

          samisa Don Samisa Abeysinghe added a comment - Yes I too think that this is not any more needed. What we really do is to map the Fault details to an exception. So those who want fault details should deal with the exception.

          SoapDeSerializer too has a getFaultDetail (called b by Call->getFaultDetail() ) and a getFault().
          Those too need be removed as they are no more needed along with the m_pcFaultDetail member in SoapDeSerializer class.

          samisa Don Samisa Abeysinghe added a comment - SoapDeSerializer too has a getFaultDetail (called b by Call->getFaultDetail() ) and a getFault(). Those too need be removed as they are no more needed along with the m_pcFaultDetail member in SoapDeSerializer class.

          Removed Call->getFaultDetail(char** ppcDetail) including unused stuff in SoapDeSerializer class.

          samisa Don Samisa Abeysinghe added a comment - Removed Call->getFaultDetail(char** ppcDetail) including unused stuff in SoapDeSerializer class.

          People

            samisa Don Samisa Abeysinghe
            perryan Andrew Perry
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: