[AXISCPP-284] Problem returning a pointer with c_str() to an unnamed string object in SimpleAxisTransport.cpp

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3 Final
• Fix Version/s: 1.4 Alpha
• Environment: Windows
• Assignee: Don Samisa Abeysinghe
• Reporter: Don Samisa Abeysinghe
• Created: 25/Nov/04 08:24
• Updated: 05/Apr/06 21:03
• Resolved: 25/Nov/04 09:09

Description

On Wed, 24 Nov 2004, Steve Hardy wrote:

> Hey there,
>
> I was looking at why axis doesn't want te run on my win32 platform,
and
> came across the following (bad) problem:
>
> SimpleAxisTransport.cpp, line 244:
>
> return m_strSOAPAction.substr(uiOpStart,
> m_strSOAPAction.length () -
> uiOpStart).c_str();
>
> This is a bad thing because you are returning a pointer with
c_str()
to
> an unnamed string object (the one returned by substr) which is out of
> context when you return the function. This seems to work in linux,
(as
> long as the stack isn't clobbered), but in windows this fails in
debug
> mode for sure, and probably in release mode too (MSVC++ 6.0).
>
> I'd recommend recoding this to returning a string object or having a
> c_str() pointer from the m_strSOAPAction object as this doesn't go
out
of
> context.
>
> Yours,
> Steve Hardy

And the same problem on line 230 with m_strServiceURI

fixing these two problems (and using Xerces, expat didn't seem to
work),
fixes the simpleserver on win32.