[AXIS2C-397] Rampart Utils - Some Code Improvements

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: rampart
• Environment: All
• Assignee: Malinda Kaushalye Kapuruge
• Reporter: Nabeel Yoosuf
• Created: 08/Nov/06 05:23
• Updated: 07/Apr/20 17:45
• Resolved: 11/Dec/06 04:35

Description

I had a quick glance at some of the files in rampart utils..Some suggestions

1. In some functions the same value is recalculated several times which is not efficient.
E.g.
rampart_utils.c:rampart_generate_nonce(..)
OXS_BUFFER_GET_SIZE(buffer, env)

rampart_cryto_utils.c:rampart_crypto_sha1(..)
axis2_base64_decode_len(nonce)

2. Memory leaks
E.g.
rampart_crypt_utils.c:45 - what is allocated is not freed

3. I find many printf's - are these for debugging? the better way is to perform a runtime debugging.

Thanks
-Nabeel