[AXIS2C-1402] AXIS2_PARAM_CHECK overwrite previously set error status

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.6.0
• Component/s: core/engine
• Assignee: Selvaratnam Uthaiyashankar
• Reporter: Selvaratnam Uthaiyashankar
• Created: 15/Oct/09 09:22
• Updated: 07/Apr/20 19:55
• Resolved: 30/Aug/11 16:09

Description

When checking AXIS2_PARAM_CHECK, if it is success, it overwrites STATUS_CODE by setting AXIS2_ERROR_SET_STATUS_CODE(error, AXIS2_SUCCESS);

check the macro definition:
#define AXIS2_PARAM_CHECK(error, object, error_return) \
if (!object) \

{ \ AXIS2_ERROR_SET_ERROR_NUMBER(error, AXIS2_ERROR_INVALID_NULL_PARAM); \ AXIS2_ERROR_SET_STATUS_CODE(error, AXIS2_FAILURE); \ return error_return; \ }

\
else \

{ \ AXIS2_ERROR_SET_STATUS_CODE(error, AXIS2_SUCCESS); \ }

Ideally, if PARAM_CHECK is success, it should not touch error status code.

This macro is a problem when sending soap faults from generated code. To send faults from generated code, we have to set the error status inside service logic and it will be checked by the engine to create soap fault. However, after setting error status, there are several generated codes doing AXIS2_PARAM_CHECK and hence overwriting the status code.