Uploaded image for project: 'Axis2-C'
  1. Axis2-C
  2. AXIS2C-1325

_WIN32 should be used instead of WIN32

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.5.0
    • 1.7.0
    • build system (Windows)
    • None
    • WIN64

    Description

      In several places, the WIN32 macro is used to check if we're running on Windows or not. This macro is defined in the make file (and usually by VS in the any WIN32 project too).
      However, when users are using the library in a 64-bit windows environment, WIN32 is not defined, so the tests for the WIN32 macro in the axis include files in the distribution, fail (when they should not, because we are in a windows environment).

      We should either use _WIN32 instead (which is always defined by the MS compiler in both 32-bit and 64-bit) or use something like:
      #if defined(WIN32) || defined(WIN64)
      to check for windows. I prefer _WIN32, because that's implicit defined while WIN32 and WIN64 must be defined explicit.

      This change should be made at least in the public includes (since WIN32 is defined in the makefile, the change would have no effect internally).

      Attachments

        Activity

          People

            shankar Selvaratnam Uthaiyashankar
            pvbeem Patrick van Beem
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified