[AXIS2C-1313] Memory leak in axis2_desc_add_child

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: core/description
• Environment: Win32/64
• Assignee: Manjula Peiris
• Reporter: Patrick van Beem
• Created: 09/Dec/08 12:25
• Updated: 06/Jan/09 10:11
• Resolved: 06/Jan/09 10:11

Description

axis2_desc_add_child() overwrites existing children with the same name. These become orphaned and are leaking memory (they'll never get freed).
Suggestion: Check for an existing child with the same key ad free it before replacing it with the new child:

AXIS2_EXTERN axis2_status_t AXIS2_CALL
axis2_desc_add_child(
const axis2_desc_t * desc,
const axutil_env_t * env,
const axis2_char_t * key,
const void *child)
{
if (desc->children)
{
/* Added from here */
axis2_msg_t* msg = (axis2_msg_t *) axutil_hash_get(desc->children, key, AXIS2_HASH_KEY_STRING);
if ( msg != NULL )

{ axis2_msg_free(msg, env); }

/* Added to here */
axutil_hash_set(desc->children, key, AXIS2_HASH_KEY_STRING, child);
return AXIS2_SUCCESS;
}
return AXIS2_FAILURE;
}