[AXIS2-5878] ValidateXMLFile.java:55 (XML External Entity Injection)

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Invalid
• Affects Version/s: 1.7.6
• Component/s: ide plugins
• Labels: security
• Flags: Important
• Assignee: Unassigned
• Reporter: Donald Kwakkel
• Created: 05/Sep/17 12:05
• Updated: 08/Sep/17 23:08
• Resolved: 08/Sep/17 23:08

Description

XML parser configured in ValidateXMLFile.java:55 does not prevent nor limit external entities resolution. This can expose the parser to an XML External Entities attack.

Proposed solution: Always disable external entities when creating a DocumentBuilderFactory:

	public static DocumentBuilderFactory createDocumentBuilderFactory() {
		DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
		factory.setNamespaceAware(true);
			try {
				factory.setFeature("http://xml.org/sax/features/external-general-entities", false);
				factory.setFeature("http://xml.org/sax/features/external-parameter-entities", false);
			}
			catch (ParserConfigurationException e) {
				throw new IllegalStateException(e);
			}
		return factory;
	}