Uploaded image for project: 'Axis2'
  1. Axis2
  2. AXIS2-5324

Wrong time when parsing time without time zone information with with milliseconds.

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 1.5.4, 1.6.2
    • 1.6.3, 1.7.0
    • adb
    • SuSE Linux 11.3, Windows XPSP3 DE running Tomcat6, java 1.6

    Description

      reopen of AXIS2-4719, see my comment there.
      BTW: The test testConvertToDateTime in for ConverterUtilTest does not contain any Assert.

      Attachments

        1. axis2-1.5.4.patch_AXIS2-5324.patch
          25 kB
          Martin Pischky
        2. ConverterUtil.txt
          7 kB
          Martin Pischky
        3. ConverterUtilTest.txt
          15 kB
          Martin Pischky

        Activity

          martin.pischky Martin Pischky added a comment - - edited

          Fixed this and added real test. Attached two text files with changed methodes and a patch based on AXIS2 1.5.4.
          Test is a little bit like a back to back test. Uses parts of SimleDateFormat. Tests are run in different default time zones by TimeZone.setDefault().

          Hope this helps, AXIS2 is a great tool!

          Martin

          martin.pischky Martin Pischky added a comment - - edited Fixed this and added real test. Attached two text files with changed methodes and a patch based on AXIS2 1.5.4. Test is a little bit like a back to back test. Uses parts of SimleDateFormat. Tests are run in different default time zones by TimeZone.setDefault(). Hope this helps, AXIS2 is a great tool! Martin

          Patch available on r1341780 and thanks for your contribution.

          sagara Sagara Gunathunga added a comment - Patch available on r1341780 and thanks for your contribution.
          hudson Hudson added a comment -

          Integrated in Axis2 #1503 (See https://builds.apache.org/job/Axis2/1503/)
          Fixed AXIS2-5324, added modifications and test cases extracted from given patch. This solved any remaining issues of AXIS2-4719 too. (Revision 1341780)

          Result = SUCCESS
          sagara :
          Files :

          • /axis/axis2/java/core/trunk/modules/adb/src/org/apache/axis2/databinding/utils/ConverterUtil.java
          • /axis/axis2/java/core/trunk/modules/adb/test/org/apache/axis2/databinding/utils/ConverterUtilTest.java
          hudson Hudson added a comment - Integrated in Axis2 #1503 (See https://builds.apache.org/job/Axis2/1503/ ) Fixed AXIS2-5324 , added modifications and test cases extracted from given patch. This solved any remaining issues of AXIS2-4719 too. (Revision 1341780) Result = SUCCESS sagara : Files : /axis/axis2/java/core/trunk/modules/adb/src/org/apache/axis2/databinding/utils/ConverterUtil.java /axis/axis2/java/core/trunk/modules/adb/test/org/apache/axis2/databinding/utils/ConverterUtilTest.java
          Hillerøe Silwing added a comment -

          The same technique could be applied to the method ConverterUtil.convertToDate. It has the same check of if(source.length() >= 10) which sets DST_OFFSET despite timezone not being present, causing the same issue there.

          Hillerøe Silwing added a comment - The same technique could be applied to the method ConverterUtil.convertToDate. It has the same check of if(source.length() >= 10) which sets DST_OFFSET despite timezone not being present, causing the same issue there.

          People

            Unassigned Unassigned
            martin.pischky Martin Pischky
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 2h
                2h
                Remaining:
                Remaining Estimate - 2h
                2h
                Logged:
                Time Spent - Not Specified
                Not Specified