[AXIS-1717] Anti-social size determination for attachments

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.2RC2
• Component/s: SAAJ
• Assignee: Unassigned
• Reporter: Sean Barnett
• Created: 13/Dec/04 04:40
• Updated: 26/Jan/05 03:19

Description

The following code is taken from AttachmentPart method getSize():

public int getSize() throws SOAPException {
if (datahandler == null)

{ return 0; }

ByteArrayOutputStream bout = new ByteArrayOutputStream();
try

{ datahandler.writeTo(bout); }

catch (java.io.IOException ex)

{ log.error(Messages.getMessage("javaIOException00"), ex); throw new SOAPException(Messages.getMessage("javaIOException01", ex.getMessage()), ex); }

return bout.size();
}

My understanding is that when the attachment is large the entire attachment will be stored in memory (in the ByteArrayOutputStream). This is unfortunate considering the elegant ManagedMemoryDataSource approach of keeping large attachments out of memory.

The class DimeBodyPart implementation of getDataSize() is perhaps a template for improving this behaviour.