[AXIOM-482] Attaching an OMElement to a DOM Document does not update its id attributes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 1.2.17
• Component/s: DOOM
• Assignee: Unassigned
• Reporter: Detelin Yordanov
• Created: 03/Feb/16 20:48
• Updated: 05/Feb/16 19:07
• Resolved: 05/Feb/16 10:50

Description

When using Opensaml to marshall a SAML assertion from a soap envelope built with Axiom DOOM, the resulting assertion element cannot be properly copied to a new fresh Document - the copy is successful, however searching the Document for the assertion by its id (Document.getElementById()) returns null.

It seems that Axiom Document implementation caches the id attributes (under idAttrs field) and these are not updated when a new OMElement is appended to the document.

Opensaml marshaller uses Document.adoptNode(assertion) API followed by Document.appendNode(assertion) but neither of these update the id attributes in Axiom DocumentImpl so afterwards Document.getElementById(assertionId) returns null.

I'm not quite certain that this issue is in Axiom, it might as well be in Opensaml. I'm providing a unit test that demonstrates the issue. Similar code is used in Axis2's Rampart security module when storing a processed SAML assertion to its token store.

Issue Links

• relates to: XERCESJ-1022 cloneNode forgets IDness of attribute
• links to: Avoid unnecessary serialization/deserialization and instead use DOOM directly.
• links to: Marshalling a SAML assertion into a new Document loses its ID