[AXIOM-364] Unnecessary cast to byte while scanning for first MIME boundary

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2.11
• Fix Version/s: 1.2.12
• Component/s: API
• Assignee: Andreas Veithen
• Reporter: Haihong Xu
• Created: 09/Jun/11 07:57
• Updated: 07/Jul/11 19:19
• Resolved: 10/Jun/11 20:03

Description

In the class org.apache.axiom.attachments.Attachments line 237
--->
while (true) {
int value;
try {
value = pushbackInStream.read();
if ((byte) value == boundary[0]) {
int boundaryIndex = 0;
while ((boundaryIndex < boundary.length)
&& ((byte) value == boundary[boundaryIndex])) {
value = pushbackInStream.read();
if (value == -1)

{ throw new OMException( "Unexpected End of Stream while searching for first Mime Boundary"); }

boundaryIndex++;
}
if (boundaryIndex == boundary.length)

{ // boundary found pushbackInStream.read(); break; }

} else if ((byte) value == -1)

{ <--- this byte case is unnecessary, e.g. if the value is 255, after the cast from int to byte, then from byte to int, it will be finally equal to -1 throw new OMException( "Mime parts not found. Stream ended while searching for the boundary"); }

} catch (IOException e1)

{ throw new OMException("Stream Error" + e1.toString(), e1); }

}
<---