[AXIOM-360] OMNodeImpl fails to properly set parent for insertSiblingBefore

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 1.2.11
• Component/s: LLOM
• Assignee: Andreas Veithen
• Reporter: Eric Johnson
• Created: 05/Apr/11 21:28
• Updated: 23/Jun/11 21:53
• Resolved: 23/Jun/11 21:53

Description

When attempting to use Axiom with the https://code.google.com/a/apache-extras.org/p/santuario-genxdm/, I noticed a test case that failed after trying to encrypt, then decrypt XML in the same document.

Turns out it was failing because the parent OMContainer was not being set properly on the child in OMNodeImpl.insertSiblingBefore().

If you look at OMNodeImpl.insertSiblingAfter(), it has a line:

((OMNodeEx) sibling).setParent(parent);

However, insertSiblingBefore() sets the parent differently, and misses the case where there is no previous sibling.

I marked this as a major bug, because the only way I see to work around the issue is to write to the OMNodeEx interface, an internal implementation detail.