Uploaded image for project: 'Avro'
  1. Avro
  2. AVRO-915

Large number of warnings in C++ buildsc

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: c++
    • Labels:
      None

      Description

      By default, -Wall is disabled for g++. If enabled, it gives a large number of warnings. This ticket is to fix those warnings.

      1. AVRO-915-soln.patch
        9 kB
        Thiruvalluvan M. G.
      2. AVRO-915-prob.patch
        0.7 kB
        Thiruvalluvan M. G.

        Activity

        Hide
        thiru_mg Thiruvalluvan M. G. added a comment -

        One patch demonstrates the problem and the other fixes the problem.

        The warnings due to offsetof macro cannot be suppressed because offsetof is the part of the design for serializing objects in the previous C++ API. We'll deprecate the API some day.

        Show
        thiru_mg Thiruvalluvan M. G. added a comment - One patch demonstrates the problem and the other fixes the problem. The warnings due to offsetof macro cannot be suppressed because offsetof is the part of the design for serializing objects in the previous C++ API. We'll deprecate the API some day.
        Hide
        thiru_mg Thiruvalluvan M. G. added a comment -

        If there are no objections, I'll commit this tomorrow.

        Show
        thiru_mg Thiruvalluvan M. G. added a comment - If there are no objections, I'll commit this tomorrow.
        Hide
        thiru_mg Thiruvalluvan M. G. added a comment -

        Committed revision 1182454.

        Show
        thiru_mg Thiruvalluvan M. G. added a comment - Committed revision 1182454.

          People

          • Assignee:
            thiru_mg Thiruvalluvan M. G.
            Reporter:
            thiru_mg Thiruvalluvan M. G.
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development