Avro
  1. Avro
  2. AVRO-913

CMake/C++ build should work for out-of-tree builds

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.4
    • Fix Version/s: 1.6.0
    • Component/s: c++
    • Labels:

      Description

      C++ CMake file sets the build directory to the source root and then forces build output into build/ directory under root. This breaks out-of-tree builds.

      CMake already has a facility for choosing build directory. We should use it.

      1. AVRO-913.patch
        6 kB
        Nebojsa Sabovic

        Activity

        Hide
        Nebojsa Sabovic added a comment -

        Use cmake_bin_dir/cmake_source_dir for supporting out-of-tree builds

        Show
        Nebojsa Sabovic added a comment - Use cmake_bin_dir/cmake_source_dir for supporting out-of-tree builds
        Hide
        Thiruvalluvan M. G. added a comment -

        If there are no objections, I'll commit this tomorrow.

        Show
        Thiruvalluvan M. G. added a comment - If there are no objections, I'll commit this tomorrow.
        Hide
        Thiruvalluvan M. G. added a comment -

        Committed revision 1182482.

        Show
        Thiruvalluvan M. G. added a comment - Committed revision 1182482.
        Hide
        Thiruvalluvan M. G. added a comment -

        Thank you Nebojsa.

        Show
        Thiruvalluvan M. G. added a comment - Thank you Nebojsa.

          People

          • Assignee:
            Nebojsa Sabovic
            Reporter:
            Nebojsa Sabovic
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development