Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.7.4
    • Fix Version/s: 1.7.5
    • Component/s: c
    • Labels:
    • Environment:

      N/A

    • Tags:
      snappy, c

      Description

      Hi again,

      I'd really love to have Snappy compression available in AVRO-C.

      Cheers,
      Lucas

        Activity

        Hide
        Michael Cooper added a comment -

        This should be relatively simple to implement ontop of the changes in AVRO-957.

        Show
        Michael Cooper added a comment - This should be relatively simple to implement ontop of the changes in AVRO-957 .
        Hide
        Grisha Trubetskoy added a comment -

        Here is a (git generated, sorry) diff for support for the Snappy codec in Avro-c. (This patch includes the crc32 according to the Avro spec, so that it is fully compatible with the Java version).

        Show
        Grisha Trubetskoy added a comment - Here is a (git generated, sorry) diff for support for the Snappy codec in Avro-c. (This patch includes the crc32 according to the Avro spec, so that it is fully compatible with the Java version).
        Hide
        Grisha Trubetskoy added a comment -

        Patch for Snappy (AVRO-896)

        Show
        Grisha Trubetskoy added a comment - Patch for Snappy ( AVRO-896 )
        Hide
        Grisha Trubetskoy added a comment -

        Snappy patch for Avro-C.

        Show
        Grisha Trubetskoy added a comment - Snappy patch for Avro-C.
        Hide
        Grisha Trubetskoy added a comment -

        Snappy patch for Avro-C 1.7.4 (third time's the charm)

        Show
        Grisha Trubetskoy added a comment - Snappy patch for Avro-C 1.7.4 (third time's the charm)
        Hide
        ASF subversion and git services added a comment -

        Commit 1507309 from dcreager@apache.org in branch 'avro/trunk'
        [ https://svn.apache.org/r1507309 ]

        AVRO-896. C: Snappy compression codec.

        Like all other codecs, this is optional. It will only be activated if the
        snappy C library is installed at build time. Contributed by Grisha Trubetskoy.

        Show
        ASF subversion and git services added a comment - Commit 1507309 from dcreager@apache.org in branch 'avro/trunk' [ https://svn.apache.org/r1507309 ] AVRO-896 . C: Snappy compression codec. Like all other codecs, this is optional. It will only be activated if the snappy C library is installed at build time. Contributed by Grisha Trubetskoy.
        Hide
        Douglas Creager added a comment -

        Had to fix one compiler warning (comparison of signed and unsigned values). Other than that, looks good. Merged in SVN trunk.

        Show
        Douglas Creager added a comment - Had to fix one compiler warning (comparison of signed and unsigned values). Other than that, looks good. Merged in SVN trunk.
        Hide
        ASF subversion and git services added a comment -

        Commit 1507318 from dcreager@apache.org in branch 'avro/trunk'
        [ https://svn.apache.org/r1507318 ]

        AVRO-896. C: Snappy is an optional dependency

        Buildbot doesn't have the snappy libraries installed, and it raised an error
        trying to compile the C bindings with the previous AVRO-896 patch applied.
        Turns out we weren't being careful enough when the Snappy library (and
        presumably the other compression libraries) weren't installed. Now this
        correctly results in a good build, of a library with snappy support turned off,
        as intended.

        Show
        ASF subversion and git services added a comment - Commit 1507318 from dcreager@apache.org in branch 'avro/trunk' [ https://svn.apache.org/r1507318 ] AVRO-896 . C: Snappy is an optional dependency Buildbot doesn't have the snappy libraries installed, and it raised an error trying to compile the C bindings with the previous AVRO-896 patch applied. Turns out we weren't being careful enough when the Snappy library (and presumably the other compression libraries) weren't installed. Now this correctly results in a good build, of a library with snappy support turned off, as intended.
        Hide
        ASF subversion and git services added a comment -

        Commit 1507318 from dcreager@apache.org in branch 'avro/trunk'
        [ https://svn.apache.org/r1507318 ]

        AVRO-896. C: Snappy is an optional dependency

        Buildbot doesn't have the snappy libraries installed, and it raised an error
        trying to compile the C bindings with the previous AVRO-896 patch applied.
        Turns out we weren't being careful enough when the Snappy library (and
        presumably the other compression libraries) weren't installed. Now this
        correctly results in a good build, of a library with snappy support turned off,
        as intended.

        Show
        ASF subversion and git services added a comment - Commit 1507318 from dcreager@apache.org in branch 'avro/trunk' [ https://svn.apache.org/r1507318 ] AVRO-896 . C: Snappy is an optional dependency Buildbot doesn't have the snappy libraries installed, and it raised an error trying to compile the C bindings with the previous AVRO-896 patch applied. Turns out we weren't being careful enough when the Snappy library (and presumably the other compression libraries) weren't installed. Now this correctly results in a good build, of a library with snappy support turned off, as intended.

          People

          • Assignee:
            Unassigned
            Reporter:
            Lucas Martin-King
          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development