Uploaded image for project: 'Avro'
  1. Avro
  2. AVRO-819

C library not propagating error codes when reading files

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.1
    • Fix Version/s: 1.5.2, 1.6.0
    • Component/s: c
    • Labels:
      None

      Description

      The C library's data file reader isn't propagating error codes correctly, which causes avro_file_reader_read to not correctly detect EOF. Instead, it will return as if it's reading the final block of the file twice, though it's not filling in the datum parameter for the second pass through the block.

        Activity

        Hide
        dcreager Douglas Creager added a comment -

        Here's a fix, along with a test case. Just needed to update a couple of the "check" macros in avro_private.h to return error rvals.

        Show
        dcreager Douglas Creager added a comment - Here's a fix, along with a test case. Just needed to update a couple of the "check" macros in avro_private.h to return error rvals.
        Hide
        dcreager Douglas Creager added a comment -

        Fixed in Subversion, trunk and branch-1.5

        Show
        dcreager Douglas Creager added a comment - Fixed in Subversion, trunk and branch-1.5

          People

          • Assignee:
            dcreager Douglas Creager
            Reporter:
            dcreager Douglas Creager
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development