[AVRO-759] Field alias not working due to Schema.getFieldAlias return null for fields not aliased

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.1
• Fix Version/s: 1.5.0
• Component/s: java
• Hadoop Flags: Reviewed
• Assignee: Xiaolu Ye
• Reporter: Xiaolu Ye
• Created: 08/Feb/11 15:25
• Updated: 12/Mar/11 00:32
• Resolved: 15/Feb/11 21:50

Description

When field alias is used, I get NullPointerException in Schema.Field.hashCode() because Field.name is null. This is because Schema.getFieldAlias return null for non-aliased field. Currently the code is as below:

private static String getFieldAlias(Name record, String field,
Map<Name, Map<String, String>> fieldAliases) {
Map<String, String> recordAliases = fieldAliases.get(record);
if(recordAliases == null)

{ return field; }
return recordAliases.get(field);
}

Given recordAliases only has aliases, it should return field itself if it's not in recordAliases as below:

private static String getFieldAlias(Name record, String field,
Map<Name, Map<String, String>> fieldAliases) {
Map<String, String> recordAliases = fieldAliases.get(record);
if(recordAliases == null) { return field; }

String ret = recordAliases.get(field);
if (ret == null) ret = field;
return ret;
}