[AVRO-4084] CommonsSchemasTests.cc does not compile on windows

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.12.0
• Fix Version/s: 1.13.0
• Component/s: c++
• Labels: pull-request-available

Language

C++

• Assignee: Guillaume Labourey
• Reporter: Guillaume Labourey
• Created: 24/Oct/24 21:35
• Updated: 25/Oct/24 08:20
• Resolved: 25/Oct/24 08:20

Description

***\lang\c++\test\CommonsSchemasTests.cc(44,55): Reason : cannot convert from 'const std::filesystem::path::value_type *' to 'const avro::DataFileReader<avro::GenericDatum> 

On Windows, std::filesystem::path::value_type is based on wchar_t and not on char. (std::filesystem::path). That's why DataFileReader<> constructor is not compatible with the filesystem::path default string conversion operator.

Issue Links

• links to: GitHub Pull Request #3220