[AVRO-4027] IdlReader in Avro 1.12.0 fails with NPE on complex types with empty default value

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.12.0
• Fix Version/s: 1.13.0
• Component/s: java
• Labels: pull-request-available
• Assignee: Oscar Westra van Holthe - Kind
• Reporter: Raphael Rösch
• Created: 06/Aug/24 08:55
• Updated: 05/Sep/24 09:36
• Resolved: 05/Sep/24 09:36

Description

Given this avdl (TestProtocol.avdl):

protocol TestProtocol {
    record Test {
        map<string> myMap = {};
    }
}

With Avro 1.12.0 'IdlReader' fails with a NullPointerException:

$ java -jar avro-tools-1.12.0.jar idl ./TestProtocol.avdl
Exception in thread "main" org.apache.avro.SchemaParseException: java.lang.NullPointerException: Cannot invoke "org.antlr.v4.runtime.Token.getText()" because "stringToken" is null
	at org.apache.avro.idl.IdlReader.parse(IdlReader.java:224)
	at org.apache.avro.idl.IdlReader.parse(IdlReader.java:187)
	at org.apache.avro.idl.IdlReader.parse(IdlReader.java:172)
	at org.apache.avro.tool.IdlTool.run(IdlTool.java:70)
	at org.apache.avro.tool.Main.run(Main.java:67)
	at org.apache.avro.tool.Main.main(Main.java:56)
Caused by: java.lang.NullPointerException: Cannot invoke "org.antlr.v4.runtime.Token.getText()" because "stringToken" is null
	at org.apache.avro.idl.IdlReader$IdlParserListener.getString(IdlReader.java:975)
	at org.apache.avro.idl.IdlReader$IdlParserListener.exitJsonPair(IdlReader.java:926)
	at org.apache.avro.idl.IdlParser$JsonPairContext.exitRule(IdlParser.java:2558)
	at org.antlr.v4.runtime.Parser.triggerExitRuleEvent(Parser.java:410)
	at org.antlr.v4.runtime.Parser.exitRule(Parser.java:642)
	at org.apache.avro.idl.IdlParser.idlFile(IdlParser.java:289)
	at org.apache.avro.idl.IdlReader.parse(IdlReader.java:220)
	... 5 more

With Avro 1.11.3

$ java -jar avro-tools-1.11.3.jar idl ./TestProtocol.avdl
{
  "protocol" : "TestProtocol",
  "types" : [ {
    "type" : "record",
    "name" : "Test",
    "fields" : [ {
      "name" : "myMap",
      "type" : {
        "type" : "map",
        "values" : "string"
      },
      "default" : { }
    } ]
  } ],
  "messages" : { }
}

Issue Links

• is duplicated by: AVRO-4034 Execution schemas of goal org.apache.avro:avro-maven-plugin:1.12.0:idl-protocol failed: java.lang.NullPointerException
• links to: GitHub Pull Request #3071