Avro
  1. Avro
  2. AVRO-399

Make data file interop tests work with the Python implementation

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: python
    • Labels:
      None
    1. AVRO-399.patch
      2 kB
      Jeff Hammerbacher
    2. AVRO-399.patch
      5 kB
      Jeff Hammerbacher
    3. AVRO-399.patch
      5 kB
      Jeff Hammerbacher
    4. AVRO-399.patch
      5 kB
      Jeff Hammerbacher

      Issue Links

        Activity

        Hide
        Jeff Hammerbacher added a comment -

        Patch needs a data generator added.

        Show
        Jeff Hammerbacher added a comment - Patch needs a data generator added.
        Hide
        Doug Cutting added a comment -

        We might commit this w/o a data generator and add that in a separate issue? Some interop testing is better than none.

        Show
        Doug Cutting added a comment - We might commit this w/o a data generator and add that in a separate issue? Some interop testing is better than none.
        Hide
        Jeff Hammerbacher added a comment -

        Here's an implementation of the Python data file interop and data file generator

        Show
        Jeff Hammerbacher added a comment - Here's an implementation of the Python data file interop and data file generator
        Hide
        Doug Cutting added a comment -

        This fails for me.

        > (cd lang/py; ant interop-data-generate)
        Buildfile: build.xml

        interop-data-generate:
        [mkdir] Created dir: /home/cutting/src/avro/trunk/build/interop/data
        [exec] Traceback (most recent call last):
        [exec] File "/home/cutting/src/avro/trunk/lang/py/test/gen_interop_data.py", line 2, in <module>
        [exec] from avro import schema
        [exec] ImportError: No module named avro
        [exec] Result: 1

        Show
        Doug Cutting added a comment - This fails for me. > (cd lang/py; ant interop-data-generate) Buildfile: build.xml interop-data-generate: [mkdir] Created dir: /home/cutting/src/avro/trunk/build/interop/data [exec] Traceback (most recent call last): [exec] File "/home/cutting/src/avro/trunk/lang/py/test/gen_interop_data.py", line 2, in <module> [exec] from avro import schema [exec] ImportError: No module named avro [exec] Result: 1
        Hide
        Jeff Hammerbacher added a comment -

        Oh, you want it to work on your computer, not just my own? FINE.

        Show
        Jeff Hammerbacher added a comment - Oh, you want it to work on your computer, not just my own? FINE.
        Hide
        Doug Cutting added a comment -

        The interop test now work for me, but

        ./build.sh clean; cd lang/py ; ant test

        fails with

        [py-test] OSError: [Errno 2] No such file or directory: '/home/cutting/src/avro/trunk/lang/py/test/../../../build/interop/data'

        Show
        Doug Cutting added a comment - The interop test now work for me, but ./build.sh clean; cd lang/py ; ant test fails with [py-test] OSError: [Errno 2] No such file or directory: '/home/cutting/src/avro/trunk/lang/py/test/../../../build/interop/data'
        Hide
        Jeff Hammerbacher added a comment -

        Exclude test_datafile_interop.py from being run by the "test" ant target.

        Show
        Jeff Hammerbacher added a comment - Exclude test_datafile_interop.py from being run by the "test" ant target.
        Hide
        Jeff Hammerbacher added a comment -

        Doug: try now.

        Show
        Jeff Hammerbacher added a comment - Doug: try now.
        Hide
        Doug Cutting added a comment -

        +1

        './build.sh clean test' now works for me. Thanks, Jeff!

        Show
        Doug Cutting added a comment - +1 './build.sh clean test' now works for me. Thanks, Jeff!
        Hide
        Jeff Hammerbacher added a comment -

        Committed revision 908770.

        Show
        Jeff Hammerbacher added a comment - Committed revision 908770.

          People

          • Assignee:
            Jeff Hammerbacher
            Reporter:
            Jeff Hammerbacher
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development