Avro
  1. Avro
  2. AVRO-390

ResolvingDecoder does not handle default values for records well

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: java
    • Labels:
      None

      Description

      Default values for simple fields work fine. But if a field is of type record and that field has default value, the values are inserted fine. But since the client has no knowledge that what is being read is a default value, it tries to get the field order of this record using readFieldOrder(). But the current implementation does not expect such a call. The accompanying test patch catches the problem. The actual patch fixes the problem.

      1. AVRO-390-test.patch
        3 kB
        Thiruvalluvan M. G.
      2. AVRO-390.patch
        0.8 kB
        Thiruvalluvan M. G.

        Activity

        Thiruvalluvan M. G. created issue -
        Thiruvalluvan M. G. made changes -
        Field Original Value New Value
        Attachment AVRO-390.patch [ 12431915 ]
        Attachment AVRO-390-test.patch [ 12431916 ]
        Thiruvalluvan M. G. made changes -
        Assignee Thiruvalluvan M. G. [ thiru_mg ]
        Thiruvalluvan M. G. made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Doug Cutting added a comment -

        +1 Looks good. Thanks!

        Show
        Doug Cutting added a comment - +1 Looks good. Thanks!
        Hide
        Thiruvalluvan M. G. added a comment -

        Committed revision 905520.

        Show
        Thiruvalluvan M. G. added a comment - Committed revision 905520.
        Thiruvalluvan M. G. made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Doug Cutting made changes -
        Fix Version/s 1.3.0 [ 12314318 ]
        Doug Cutting made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 1 Thiruvalluvan M. G. 01/Feb/10 17:33
        Patch Available Patch Available Resolved Resolved
        12h 2m 1 Thiruvalluvan M. G. 02/Feb/10 05:36
        Resolved Resolved Closed Closed
        27d 11h 33m 1 Doug Cutting 01/Mar/10 17:09

          People

          • Assignee:
            Thiruvalluvan M. G.
            Reporter:
            Thiruvalluvan M. G.
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development