[AVRO-3221] Verify NUL termination on set_string_len and make buffer more compact.

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: c
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Eshed Shaham
• Created: 06/Oct/21 14:44
• Updated: 06/Oct/21 14:55

Description

set_string_len expects the size to include a NUL terminator, but that's not enforced in code. In addition, when it calls avro_raw_string_set_length, that function adds another NUL terminator on top of the expected one.

Fixing both of these issues does not change the behaviour for valid inputs, and makes sure the function fails for invalid inputs (non-null terminated strings).

Issue Links

• links to: GitHub Pull Request #1352