[AVRO-3173] Rust: fix panic messages in test code

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.11.0
• Component/s: rust
• Labels: pull-request-available
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Martin Tzvetanov Grigorov
• Created: 07/Jul/21 07:50
• Updated: 03/Sep/21 13:13
• Resolved: 03/Sep/21 13:13

Description

Running `cargo test` (Rust 1.53.0) produces the following warnings:

 

warning: panic message is not a string literal
    --> tests/schema.rs:1173:13
     |
1173 |             e.to_string()
     |             ^^^^^^^^^^^^^
     |
     = note: `#[warn(non_fmt_panic)]` on by default
     = note: this is no longer accepted in Rust 2021
help: add a "{}" format string to Display the message
     |
1173 |             "{}", e.to_string()
     |             ^^^^^warning: 1 warning emitted
 

 

 warning: panic message is not a string literal
   --> tests/io.rs:105:13
    |
105 |             format!("value {:?} does not validate schema: {}", value, raw_schema)
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(non_fmt_panic)]` on by default
    = note: this is no longer accepted in Rust 2021
    = note: the panic!() macro supports formatting, so there's no need for the format!() macro here
help: remove the `format!(..)` macro call
    |
105 |             "value {:?} does not validate schema: {}", value, raw_schema
    |            --                                                          --warning: 1 warning emitted

Issue Links

• links to: GitHub Pull Request #1283
• links to: Pull Request