Avro
  1. Avro
  2. AVRO-292

Add a test to be sure the skip_int and skip_long functionality is working correctly in Python implementation

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: python
    • Labels:
      None

      Description

      The current Python implementation skips a fixed number of bytes for integers and longs, but we use a variable-length encoding scheme. I suspect there's a flaw there.

      1. AVRO-292.patch
        8 kB
        Jeff Hammerbacher

        Activity

        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Jeff!

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Jeff!
        Hide
        Jeff Hammerbacher added a comment -

        This patch implements correct behavior for io#skip_int() and io#skip_long() and adds tests. I also took the liberty to convert some self.reader.read() calls in io.py to self.read(), since that helper function is available--just housekeeping.

        Show
        Jeff Hammerbacher added a comment - This patch implements correct behavior for io#skip_int() and io#skip_long() and adds tests. I also took the liberty to convert some self.reader.read() calls in io.py to self.read(), since that helper function is available--just housekeeping.

          People

          • Assignee:
            Jeff Hammerbacher
            Reporter:
            Jeff Hammerbacher
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development