[AVRO-2833] [Python] lint fails with pycodestyle 2.6.0

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Assignee: Ryan Skraba
• Reporter: Ryan Skraba
• Created: 13/May/20 15:44
• Updated: 02/Jul/20 12:22
• Resolved: 13/May/20 18:48

Description

It looks like our code fails the lint since the recent update of pycodestyle from 2.5.0 to 2.6.0.

+cd lang/py
+ ./build.sh lint test
GLOB sdist-make: /home/travis/build/RyanSkraba/avro/lang/py/setup.py
lint create: /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint
lint installdeps: isort, pycodestyle
lint inst: /home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0+snapshot.zip
lint installed: avro @ file:///home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0%2Bsnapshot.zip,isort==4.3.21,pycodestyle==2.6.0
lint run-test-pre: PYTHONHASHSEED='3539139953'
lint run-test: commands[0] | isort --check-only
Skipped 1 files
lint run-test: commands[1] | pycodestyle
./avro/test/test_datafile_interop.py:30:1: E302 expected 2 blank lines, found 1
1       E302 expected 2 blank lines, found 1
ERROR: InvocationError for command /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint/bin/pycodestyle (exited with code 1)

This can be reproduced locally (and on all PR checks since May 11th).

We could pin pycodestyle to 2.5.0, but we should also listen to the lint and fix this whitespace.