[AVRO-2804] Generated Avro schema from Thrift is missing default values

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.8.2, 1.9.2
• Component/s: java
• Assignee: Unassigned
• Reporter: Zezeng Wang
• Created: 16/Apr/20 06:29
• Updated: 16/Apr/20 07:05

Description

Hi,

Currently, using the thrift class to generate Avro's schema, there is missing default values.

In our project, the business data will be transmitted through the Thrift framework and saved in the avro file, and then use GenericRecord to perform business delivery on various other business platforms, but use this schema for data deserialization, there is no default value for the field, resulting in Troublesome work.

Thrift's IDL:

namespace java org.apache.avro.thrift.test
struct SimpleDefault{

1: i16 im_default = 6;

2: required i16 im_required = 6;

3: optional i16 im_optional = 6;

}

Generated Schema for using ThriftData:

{
  "type":"record",
  "name":"SimpleDefault",
  "namespace":"org.apache.avro.thrift.test",
  "fields":[{
    "name":"im_default",
    "type":{
      "type":"int",
      "thrift":"short"
    }
  },{
    "name":"im_required",
    "type":{
      "type":"int",
      "thrift":"short"
    }
},{
    "name":"im_optional",
    "type":["null",{
      "type":"int",
      "thrift":"short"
    }]
}]
}
 

Default value is missing.

Deserialization (GenericDatumReader):

{

  "im_default":6,

  "im_required":6,

  "im_optional":null

}

I am trying to add a default value in ThriftData because I found that it is not set.
https://github.com/apache/avro/blob/9af218d3c060da103868cdc69d7b39fc8d50dcbc/lang/java/thrift/src/main/java/org/apache/avro/thrift/ThriftData.java#L197