[AVRO-2790] Necessity of using Object as parameter of javaEscape method

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.2
• Fix Version/s: 1.10.0
• Component/s: java
• Assignee: Zezeng Wang
• Reporter: Zezeng Wang
• Created: 03/Apr/20 03:01
• Updated: 02/Jul/20 12:22
• Resolved: 26/Apr/20 10:01

Description

Hi,

The javaEscape method in SpecificCompiler is a utility used by templates. Escaping quotes and backslashes, which means it's dealing with strings.
And I checked the caller (enum.vm, fixed.vm) of javaEscape, all passed in as java.lang.String,
So I'm sure this should use java.lang.String as the input parameter and remove unnecessary Object.toString operations.

 

Cheers,
Ze Zeng

Issue Links

• links to: GitHub Pull Request #858