Uploaded image for project: 'Apache Avro'
  1. Apache Avro
  2. AVRO-2790

Necessity of using Object as parameter of javaEscape method

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.2
    • Fix Version/s: 1.10.0
    • Component/s: java
    • Labels:
      None

      Description

      Hi,

      The javaEscape method in SpecificCompiler is a utility used by templates. Escaping quotes and backslashes, which means it's dealing with strings.
      And I checked the caller (enum.vm, fixed.vm) of javaEscape, all passed in as java.lang.String,
      So I'm sure this should use java.lang.String as the input parameter and remove unnecessary Object.toString operations.

       

      Cheers,
      Ze Zeng

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                zeshuai007 Zezeng Wang
                Reporter:
                zeshuai007 Zezeng Wang
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: