[AVRO-2628] SpecificCompiler erases Logical Types when string type is set to StringType.String

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.9.0, 1.8.2, 1.9.1
• Component/s: java
• Assignee: Unassigned
• Reporter: Matthias Klein
• Created: 14/Nov/19 19:42
• Updated: 15/Nov/19 14:15

Description

SpecificCompiler::compile(Schema) always calls addStringType on the Schema first. If SpecificCompiler::stringType is not StringType.String, this is a No-Op and Custom Conversions work as desired. However, if stringType IS set to StringType.String, the Schema is deep copied to patch the String Types (why?), thereby loosing all Logical Types. This, in turn, prevents Conversions from being applied.  

A possible fix (haven't tried yet) might be to add

private Schema addStringType(Schema s, Map<Schema, Schema> seen) {
{{ }}

...

  result.addAllProps(s);
+ result.SetLogicalType(s.getLogicalType());
  seen.put(s, result);
  return result;
}

Issue Links

• duplicates: AVRO-2548 StringType of "String" causes logicalType converters to be ignored for field