Description
https://github.com/apache/avro/blob/master/lang/py/test/test_tether_word_count.py needs to be refactored:
It's contained almost entirely in a single function. Setup and teardown should be isolated from the test itself.Most of the code takes place in a large try/finally block that can obscure legitimate test failures.- The test creates unnecessary files. Instead of creating a script to export PYTHONPATH, we can use subprocess.Popen's env parameter to provide the environment we want.
The exit status of the subprocess itself is not checked, which can lead to missed test failures.(Fixed in #693)
Attachments
Issue Links
- is blocked by
-
AVRO-2624 Avoid ByteBuffer incompatibility when compiling with JDK9+
-
- Closed
-
- links to
(2 links to)