[AVRO-2489] Build error C3861: 'sleep': identifier not found

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.9.0
• Fix Version/s: 1.9.1
• Component/s: c++
• Labels: build

Environment

Windows Server 2016,

VS2019,

cmake 3.15,

vcpkg 2019.06.26

Jenkins 2.186

• Assignee: Daniel Kulp
• Reporter: Andrew Ripa
• Created: 30/Jul/19 09:50
• Updated: 31/Jul/19 09:14
• Resolved: 30/Jul/19 22:15

Description

Steps to reproduce:

• Fetched 1.9.0 repo https://github.com/apache/avro/releases/tag/release-1.9.0 from git and  cd to 'lang/c++' folder
• Project generated with 

mkdir _build
cd _build
cmake -G "Visual Studio 16 2019" -A x64 .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE="PATH_TO_vcpkg.cmake" -DCMAKE_INSTALL_PREFIX="PATH_TO_INSTALL"

• Built with

cmake --build . --config Release

• Installed with

cmake --build . --config Release --target Install

During the last (install) step received an error

PATH_TO_WORKSPACE\workspace\avro\avro\lang\c++\test\DataFileTests.cc(592,13): error C3861:  'sleep': identifier not found [PATH_TO_WORKSPACE\workspace\avro\avro\lang\c++\_build\DataFileTests.vcxproj]

 

Possible hotfix found https://social.msdn.microsoft.com/Forums/vstudio/en-US/fdc9d1c3-1082-4c0d-a717-a39313562d4f/sleep?forum=vclanguage

Need to change 'sleep(1)' to 'Sleep(1)' in lang/c++/testDataFileTests.cc
After that build (and install) completed without errors