Major Description
The C# tests on the Travis CI build stopped working with build 588 on master. The previous build on master, build 585 worked fine. It is not clear what changes in between these two builds cause this failure.
From the build log, here's the before and after:
before/passing
+ dotnet test --configuration Release --framework netcoreapp2.0 ./src/apache/test/Avro.test.csproj Microsoft (R) Build Engine version 16.0.450+ga8dc7f1d34 for .NET Core Copyright (C) Microsoft Corporation. All rights reserved. Restore completed in 23.61 ms for /testptch/unknown/lang/csharp/src/apache/main/Avro.main.csproj. Restore completed in 1.8 sec for /testptch/unknown/lang/csharp/src/apache/test/Avro.test.csproj. Test run for /testptch/unknown/lang/csharp/src/apache/test/bin/Release/netcoreapp2.0/Avro.test.dll(.NETCoreApp,Version=v2.0) Microsoft (R) Test Execution Command Line Tool Version 16.0.1 Copyright (c) Microsoft Corporation. All rights reserved. Starting test execution, please wait... Total tests: 510. Passed: 510. Failed: 0. Skipped: 0. Test Run Successful. Test execution time: 59.5706 Seconds + exit 0
after/failing
+ dotnet test --configuration Release --framework netcoreapp2.0 ./src/apache/test/Avro.test.csproj Microsoft (R) Build Engine version 16.0.450+ga8dc7f1d34 for .NET Core Copyright (C) Microsoft Corporation. All rights reserved. Restore completed in 24.32 ms for /testptch/unknown/lang/csharp/src/apache/main/Avro.main.csproj. Restore completed in 1.68 sec for /testptch/unknown/lang/csharp/src/apache/test/Avro.test.csproj. Test run for /testptch/unknown/lang/csharp/src/apache/test/bin/Release/netcoreapp2.0/Avro.test.dll(.NETCoreApp,Version=v2.0) Microsoft (R) Test Execution Command Line Tool Version 16.0.1 Copyright (c) Microsoft Corporation. All rights reserved. Starting test execution, please wait... Exception System.NullReferenceException, Exception thrown executing tests in /testptch/unknown/lang/csharp/src/apache/test/bin/Release/netcoreapp2.0/Avro.test.dll Object reference not set to an instance of an object. at System.Globalization.CalendarData.NormalizeDatePattern(String input) at System.Globalization.CalendarData.LoadCalendarDataFromSystem(String localeName, CalendarId calendarId) at System.Globalization.CalendarData..ctor(String localeName, CalendarId calendarId, Boolean bUseUserOverrides) at System.Globalization.CultureData.GetCalendar(CalendarId calendarId) at System.Globalization.CultureData.DateSeparator(CalendarId calendarId) at System.Globalization.DateTimeFormatInfo.InitializeOverridableProperties(CultureData cultureData, CalendarId calendarId) at System.Globalization.CultureInfo.get_DateTimeFormat() at System.Globalization.DateTimeFormatInfo.get_CurrentInfo() at System.DateTimeFormat.Format(DateTime dateTime, String format, IFormatProvider provider, TimeSpan offset) at System.DateTimeFormat.Format(DateTime dateTime, String format, IFormatProvider provider) at NUnit.Framework.Internal.TestResult.AddToXml(TNode parentNode, Boolean recursive) at NUnit.Framework.Api.FrameworkController.RunTests(Action`1 callback, String filter) No test is available in /testptch/unknown/lang/csharp/src/apache/test/bin/Release/netcoreapp2.0/Avro.test.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again. Additionally, path to test adapters can be specified using /TestAdapterPath command. Example /TestAdapterPath:<pathToCustomAdapters>. + exit 0
Of additional concern is that the build.sh still exits with a 0 code, even though there was a clear failure.