[AVRO-2425] CMake error message for C bindings is misleading

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: c
• Assignee: Kengo Seki
• Reporter: Kengo Seki
• Created: 18/Jun/19 06:46
• Updated: 02/Jul/20 12:23
• Resolved: 28/Jun/19 14:50

Description

I tried to build C bindings and got the following error:

$ cd lang/c
$ ./build.sh dist

(snip)

-- Searching for asciidoc...
CMake Warning at docs/CMakeLists.txt:51 (message):
  asciidoc not found.  HTML documentation will *NOT* be built.


-- Configuring done
-- Generating done
-- Build files have been written to: /home/sekikn/repo/avro/build/c
cp: cannot stat '../../build/c/docs/*.html': No such file or directory

So I checked if asciidoc was installed, but I couldn't see any problem. After all, the actual lacked package was source-highlight. I think the above message is misleading.

lang/c/docs/CMakeLists.txt

find_program(ASCIIDOC_EXECUTABLE asciidoc)
find_program(SOURCE_HIGHLIGHT_EXECUTABLE source-highlight)

if (ASCIIDOC_EXECUTABLE AND SOURCE_HIGHLIGHT_EXECUTABLE)

(snip)

else(ASCIIDOC_EXECUTABLE AND SOURCE_HIGHLIGHT_EXECUTABLE)
    message(WARNING "asciidoc not found. HTML documentation will *NOT* be built.")

Issue Links

• links to: GitHub Pull Request #547